Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add apache license #8

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Add apache license #8

merged 4 commits into from
Oct 16, 2024

Conversation

cottinisimone
Copy link
Contributor

No description provided.

@cottinisimone cottinisimone requested a review from a team October 16, 2024 11:54
@cottinisimone cottinisimone requested a review from a team as a code owner October 16, 2024 11:54
MaeIsBad
MaeIsBad reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@MaeIsBad MaeIsBad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also add it to the mix.exs file, so automatic tools can find it

MaeIsBad
MaeIsBad reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@MaeIsBad MaeIsBad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking

mix.exs Show resolved Hide resolved
mix.exs Outdated Show resolved Hide resolved
LICENSE.md Outdated Show resolved Hide resolved
MaeIsBad
MaeIsBad approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@MaeIsBad MaeIsBad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works

@cottinisimone cottinisimone merged commit 6011c97 into master Oct 16, 2024
3 checks passed
@cottinisimone cottinisimone deleted the add-apache-license branch October 16, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaeIsBad MaeIsBad MaeIsBad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cottinisimone @MaeIsBad